NFT preview card component css.

Community feedback

• 

  Zsolt Varjú•490

  @zsoltvarjuPosted over 1 year ago

  Hello Igmacoi!

  I really like your solution, especially the part where you added the hover effect on the image. I love it!

  I would like to give you some suggestions:

  • You could set your body's height to min-height: 100vh instead of height: 100vh. This way, if the container needs to be bigger, it can. I know that it may not be relevant in this project, but I read somewhere that we should avoid using fixed heights whenever we can because of responsiveness. So, I think it is good to practice.

  • As I mentioned, I really like your approach to the hover effect. However, if you have the time, you should look into the ::before and ::after pseudo-classes, which are a great way to achieve the same effect without adding extra HTML to your index page.

  • In the beginning, you started to add comments in the root section. I think it would be more consistent if you added comments to the whole CSS. It does not need to be very detailed, just mention which part of the design starts where. This makes it a lot easier to read for others and for you too if you plan to revisit the project later. Anyway, keep in mind that these are just suggestions, and your project is great just the way it is.

  Keep up the good work and happy coding! :)

  2