NFT preview card component challenge hub

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Phi, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • use p tag and not h2 fort the normal text
  • to make it look as close to the design as possible add background: transparent to .view_icon class
  • try to add a little transition on the element with hover effect
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  1
• 

  Shamil ussain c•70

  @shamilussaincPosted over 2 years ago

  Hey @PhiThai1309, Nice work.

  But there is a small issue which prevents loading your CSS files. I have checked your code and where you specified <link rel="stylesheet" href="style.css"> this will look for the css file in the root directory ie, https://phithai1309.github.io/style.css

  to connect with CSS file in the same directory you have to specify <link rel="stylesheet" href="./style.css"> which will try to get https://phithai1309.github.io/nft-preview-card-component-main/style.css as ./ tell that the file is located in the same folder as the requesting file.

  hope it will helpful. happy learning.

  Marked as helpful

  0

  ---

  

  Phi Thai•30

  @PhiThai1309Posted over 2 years ago

  @shamilussainc Thank you for your comment, I have fixed the code, and it now works as perfectly!

  1
• 

  Nuel•70

  @nuelobetoPosted over 2 years ago

  Hi. Seems your css didn't load on your live site. Try removing the forward slash in the href of your css link.

  This: <link rel="stylesheet" href="style.css">

  Instead of this: <link rel="stylesheet" href="/style.css">

  0