NFT preview card component challenge

Community feedback

• 

  Adriano•38,390

  @AdrianoEscarabotePosted about 2 years ago

  Hi @Samjolas, how are you? Yes it's me again ahahahahh

  You did a great job on this challenge, but I have some advice for you:

  I noticed the page has a scrollbar, to fix this we can do the following:

  body { /* margin: 1rem 4rem; */ padding: 1rem 4rem; }

  the margin was creating the scrollbar.

  The rest is really good! You did a great job on the responsiveness of the project

  Hope it helps... 👍

  Marked as helpful

  1

  ---

  

  Samuel Jolayemi•190

  @SamjolasPosted about 2 years ago

  Hello @AdrianoEscarabote

  Thank you so much, I made the correction.

  Look forward to more helpful feedbacks from you.

  0
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Samuel Jolayemi,

  Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:

  HTML

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  • For the same reason, you can use <a> to wrap Equilibrium #3429 and Jules Wyvern.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • Never use <div> and <span>alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • For middle part of the card class="preview__details", you can use an unordered list <ul>, in each <li> there should be <img> and <p>. That way you can align them centrally.

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>you can use border-top: to the avatar's part.

  • According to MDN , <aside> HTML element represents a portion of a document whose content is only indirectly related to the document's main content. Asides are frequently presented as sidebars or call-out boxes. For this challenge, it’s only one component , I would not use <aside>.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.

  Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Samuel Jolayemi•190

  @SamjolasPosted about 2 years ago

  @PhoenixDev22

  Thank you so much for this feedback, I tried the pseudo-element::after and it worked.

  You can review my code and share your thought if all you said has been corrected. Thanks

  0