Gunjan Lunkad• 70
@glunkad
Posted
It is written in the simplest and most readable way and is designed using the display flex feature. 😀😀
Marked as helpful
0
@Buf3r
Posted
@9gl hi bro thanks u, i hope u like my work :)
0
Submitted
principal box use display: flex and margin: auto for center, css pure
@Buf3r
Design comparison
Solution retrospective
i hope like to peoples and if wrong, just say me i try fix it, thanks for view
Community feedback
Sinisa Vukmirovic• 1,690
@SinisaVukmirovic
Posted
Hello!
To improve start with fixing those report errors.
This "Document should have one main landmark" means you are missing <main> semantic element in your html. Landmark just means element.
This "All page content should be contained by landmarks" means all non-semantic elements should be inside of semantic elements, and not directly inside of <body> element.
Try to use semantic elements in your HTML. More about semantic elements
Also, it is a good practice to import google fonts in your CSS file, not HTML. You are setting "font-family" in the CSS, right? It makes sense to import it there, too.
Hope this helps!
Marked as helpful
0
@Buf3r
Posted
@SinisaVukmirovic hi bro good afternoon, bro what mean " landmarks", my english its a bit poor, but i understand mean "landmarks", so many errors about this
0
Sinisa Vukmirovic• 1,690
@SinisaVukmirovic
Posted
@Buf3r Click on that link semantic elements that I gave you in the comment above.
<main>
This is a landmark. Landmark just means HTML semantic element.
</main>
<section>
This is a landmark. Landmark just means HTML semantic element.
</section>
<article>
This is a landmark. Landmark just means HTML semantic element.
</article>
Marked as helpful
0
@Buf3r
Posted
@SinisaVukmirovic ah ok ok jejeje sorry something use all divs, i forget it but every use on another challenges, thanks bro
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord