NFT Preview Card Component built with React, TS, and Styled Components

Community feedback

• 

  Gustavo•200

  @GushigustavoPosted over 2 years ago

  Your designer is great, I would like to give you two tips, the first is that the hover in the image is having an abrupt entry, you could improve by adding a transition so that the entry is smoother, the second is about accessibility, try to involve your design into semantic tags that will help both the programmer and the browser. Let's code!!

  Marked as helpful

  1
• 

  Adam Mescher•180

  @AdamMescherPosted over 2 years ago

  Appreciate the nudge for accessibility testing before submission.

  Found a great article with a really simple snippet to use what I already have with one extra npm module to automate axe testing with jest as a test case. No association beyond stumbling and finding with Google - https://maxrozen.com/automatic-a11y-testing-with-jest-axe

  I certainly need semantic tags when rendering the application.

  The h1 accessibility issue is a bit of a mislead, IMO. I'm not sure that if I were to import this component into an already existing project that I would want that many h1 tags. Perhaps I'm way over thinking it.

  And yes, CSS transition looks much better than without.

  Appreciate your feedback.

  1