Design comparison
SolutionDesign
Solution retrospective
Any feedback is welcome!
Community feedback
- @dewslysePosted almost 3 years ago
Hello @Wissemh, congrats on your submission. Your card looks good. Some things to note:
- The image on the card is not perfectly centred. This is because of 👇
.firstimg { width: 85%; margin: 2.5vh; }
You should delete those properties and set a
max-width
on.firstimg
to 100%.- You should also add a max-width (e.g. 375px) and some padding (e.g. 25px) to your
main
. You can do away withwidth: 45vh;
on the main because it serves no purpose. You could also do away with theheight: 75vh;
and adjust the height of the card by applying some margins/padding to the elements on the card.
Happy coding!!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord