NFT preview card component

Community feedback

• 

  Alok Suman•2,380

  @Alokray007Posted 9 months ago

  Hello there 👋

  Good job on completing the challenge !

  Your project looks really good!

  I have a suggestion about your code that might interest you.

  There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

  📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope this suggestion is useful for future projects.

  Other than that, great job!

  Happy coding.

  Marked as helpful

  0

  ---

  

  Rory McPherson•70

  @rorymcphersonPosted 9 months ago

  Thank you for the helpful suggestions @Alokray007!

  I have not heard of Perfect Pixel before and I have certainly felt like I've been doing a lot of guessing at the dimensions of things. I will look into this.

  I also appreciate the note about using semantic element tags. I'm aware of these, but have not been implementing these like I could be, so thanks for the friendly reminder! I'll keep this in mind going forward.

  0