Design comparison
SolutionDesign
Solution retrospective
Hi all,
All the feedback is highly appreciated.
Thank you :D,
Giorgian
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The "NFT image"
alt tag
description needs to be improved upon ⚠️. Assume that you are describing the image to a someone over the phone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The “icons” in this component are purely decorative. ⚠️ Their
alt tag
should be left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
[MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)
- The profile image
alt tag
needs to be improved ⚠️. It should only state the following; “Headshot of -person’s full name-“
More Info:📚
- Wrap the "NFT image", "Equilibrium #3429" and "Jules Wyvern" in an
anchor tags
⚠️. Theanchor tag
will allow users to click on content and have them directed to another part of your site.
More Info:📚
- For improved accessibility 📈 for your content, it is best practice to use
rem
for yourfont-size
and other property values. Using this unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful1 - The "NFT image"
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord