nft preview card component

Community feedback

• 

  Shalom2935•420

  @Shalom2935Posted over 1 year ago

  Hello @Tosinjoseph these some advices to improve your code:

  • Change h2 to h1 and give your img an alt to fix the accebility issues.
  • Don't give a fix height and width to .all cause it will prevent your site from being responsive, if you want it to take all the screen size you can use the css code

  body{
        height: 100vh;
        width:100vw;
  }
   .all{
       width:100%;
       height:100%;
  }
  

  • It must have been really tiring to give all these margin and paging in order to dispose your element on the page; that is not a good habit you will struggle a lot doing it every time and it won't even work. Instead, it will be better for you to learn css flexbox, you will have a lot of fun using it and it will save your time.
  • You might have noticed this but the color you used on the .container background is wrong.

  Hope I have help you somehow, and you will have a happy coding journey

  0