Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT preview card component

Bashaā€¢ 330

@Bashamega

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello:) I have create this component and I had fun creating it with html and css

Community feedback

Mennatallah Heshamā€¢ 1,490

@Mennatallah-Hisham

Posted

Hi Bashamega,

You did great šŸ‘

Here are some suggestions to improve your code:

<span> & <p>

  • ** it is not a good practice to nest span**. The span tag is an inline element that you use to make a smaller part of content stand out with CSS or JavaScript.
 <p>Creation of <span id="creator">Jules Wyvern</span></p>
  • <p> should be used for **body text**
  • <p>Our Equilibrium collection promotes balance and calm</p>

ALT

  • images should have descriptive alt text, which is important for SEO and screen reader users

ICONS

  • for decorative icons that don't convey meaning you can add **aria-hidden="true" so it can be skipped by screen readers.

here are some helpful articles:

Hope you find this helpful, Happy Coding

1

Bashaā€¢ 330

@Bashamega

Posted

@Mennatallah-Hisham

Thanks

1
LDX_DEVā€¢ 190

@ledoux25

Posted

Hello coder

-check up the style-guide.md to have informations such as sizes and color codes you may need during your coding

-An easy way to center your elements and make them easily responsive is by using flex-box

-Instead of using an hr to draw that line you can use the css prop ::after (you can view my code to see what i'm talking about)

  • Add some boder raduis to the image as well and reduce it size -And you should take care when sizing your elements so the overall result is SMART

I'M NEITHER A TEACHER NOR A GOOD CODER AND I HAVE A BAD ENGLISH BUT HOPE THIS HELPS YOU BRO WISH YOU GOOG LUCK ON YOUR COODING JOURNEE

0

Bashaā€¢ 330

@Bashamega

Posted

@ledoux25

Thank you

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord