Frontend Mentor | NFT preview card component

Community feedback

• 

  Alamin•2,000

  @CodeWithAlaminPosted almost 2 years ago

  Hi Pankaj Bisen👋 Great job on completing this challenge! 🥳

  Overall, your code for the NFT preview card component is well-organized and easy to read. You have used good formatting practices, such as indenting nested elements and using descriptive class names, which makes the code easy to understand.

  One thing that I noticed is that you have included some duplicate styles in your CSS code. For example, you have defined the same styles for the .element img and .element .overlay selectors multiple times. To make your code more efficient, you should remove these duplicate styles and ensure that each style is only defined once.

  Another thing you could consider is using more semantic HTML tags to better convey the purpose of each element in your code. For example, instead of using a div element for the main container, you could use a section element. This would make your code easier for others to understand and maintain.

  Overall, your code is a good start for creating an NFT preview card component. With a few adjustments, it could be even better! Keep up the good work.

  Overall, this is a very well done solution to the challenge. Great job!

  I hope this feedback was helpful. 😊 Keep up the good work!👍

  1

  ---

  

  Pankaj Bisen•70

  @packerpotPosted almost 2 years ago

  Hey @CodePapa360 Thank you for your helpful suggestion, and I'm really sorry for the multiple selectors; it's one of my bad habits to align an element first, then add typography, color, background, etc. anyway thanks a lot.

  0