Html and Css

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Cool solution!

  To improve semantics, make sure to wrap the entire code in the main tag not including header or footer tags. It will help to remove report issues and improve accessibility as well.

  IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩

  Marked as helpful

  0

  ---

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 2 years ago

  @catherineisonline, please ensure you're not asking people to mark your comment as helpful. This goes against our community guidelines and can result in your account being flagged if this continues.

  Please also be sure not to simply repeat what is presented in the accessibility report, which also goes against our community guidelines.

  Marked as helpful

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues.

  To center a content on a page, add min-height:100vh; display: grid; place-items: center; instead of giving .container a margin value.

  Give .container a fixed width instead of percentage width in the desktop design , in the media query for the mobile design you can give .container a percentage width of 80.

  There is no need to give .container .img position: relative.

  Hope am helpful Well done for completing this challenge, you did a good job. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Oluwasegun Benjamin Tobi•400

  @BensaxxyPosted almost 2 years ago

  @Hassiai thanks so much ma'am, I will work on that ASAP ☺️

  0