Skip to content
Submitted over 1 year ago

NFT preview card component

Adham El Samahy•250
@AdhamElSamahy909
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

All feedback is welcome!!

Community feedback

  • Atif Iqbal•3,200
    @atif-devPosted over 1 year ago

    Hi Adham El Samahy, congrats🎉 on completing the challenge. Better take care about following points.

    • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. Use alt (alternate text) attribute as it is mentioned in your Accessibility Report. alt attribute is used for Screen readers technology. Why alt attribute matters? Read here. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

    (why main matters? Read here)

    • For proper centering the container(whole card) vertically and horizontally you can use code as:
    body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}

    Or you can learn centering from here.

    • Text "ETH" is not properly aligned. For fixing this issue include width: 110%; in .ETH-number selector.
    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
    • Include a README file in your GitHub project's solution and write about your working flow, findings, new learned things, useful resources, etc.

    If the Feedback is Helpful for you, Don't Forget to upvote and click on MARKED AS HELPFUL 😇......That Will Make My Day😇

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord