Design comparison
Community feedback
- @Alucard2169Posted almost 3 years ago
Hi there @Rashmi-Wijesekara Nice work on this project 🎉🎉🎉
It looks good so far,
-
Next thing you can do is, add a hover effect on the image.
-
The mobile version is not completely centered (Vertically), so you can do something about that.
-
The Desktop version is too close to the top, you can either use flex on body or just add some margin-top to the card, but i would suggest using flex.
-
there are some issues with the accessibility and that's cause
-
in your HTML file, a image tap must have an
alt
attribute. It will describe the image to the client in case the image is not loading.
I hope this helps you.
Nice work, Keep It Up 🥳🥳🥳
Marked as helpful1@Rashmi-WijesekaraPosted almost 3 years agoHi @Alucard2169
Thank you so much for your feedback it was really helpful.
This was my 1st challenge in here so I didn't realize that I should implement those hover effects also. Thanks for mentioning that.
I did some changes for which you were suggested.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord