NFT preview card component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Mahfoudh, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add descriptive text in the alt attribute of the image
  • use transition also on the title with hover effect
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Mahfoudh Arous•315

  @aladin002dzPosted over 2 years ago

  thanks for your feedback @denielden 😊.

  this is how I handled the remarks:

  • alt I added the description except for decorative elements that I don't want to be added to the accessibility APIs.
  • transition added, and it improves the UI interaction.
  • about px, I don't think it is always best to use rem, especially when we are seeking pixel-perfect results, I am not sure, I'll study the subject more.

  again thanks for your rich and nice feedback 😊🙏✌️

  1