nft preview card component

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted over 2 years ago

  Hello there! Good job in completing this challenge. Regarding your solution, I would like you to notice the following…

  • Instead of div, alternatively wrap the whole content with semantic tags, for HTML structures, refer it with this one Semantics
  • Import the attribution style in CSS file and remove the style tag
  • Add hsla(215, 51%, 70%, 1); in the root variable as soft blue and change the color in the body ruleset
  • Set the color in a ruleset into color: var(--White); and add the hover state with color: var(--Cyan);
  • Add a class in this line ...

  <div><img src="images/icon-ethereum.svg">0.041 ETH</div>
  
  Into
  <div class="sample name here"><img src="images/icon-ethereum.svg">0.041 ETH</div>
  
  Css:
  .sample name here {
      color: var(--Cyan);
  }
  

  • Add align-items: center; in the user ruleset

  In the brighter side...

  • The HTML structure is well organized and readable
  • The project is responsive and utilized the details based on the original design
  • The CSS properties is done accordingly with proper compositions and sizing elements
  • The hover state of the design is done well, specially the hero image

  Above all, the project is done well. Keep up the good work! Cheers!

  0