Skip to content
Submitted over 2 years ago

NFT preview card component

Himanshu Sahani•30
@F-a-u-x-L
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Please provide the feedback. How could have I managed the <div>(s) better?

Community feedback

  • Jasur Kurbanov•80
    @jasurkurbanovPosted over 2 years ago

    Firstly, naming If you tag contains more than one information, try to make class name generally. I mean class name should represent general idea of what you container will consist of. change from priceTime to currency-info change from avatar to author

    Secondly, not need to create so many <section/> tags. Also, you're using tags which are not need it. <main/> tag is not need it.

    Lastly. Your project structure simply can be rewritten in this way.

    <body>
    <div class="wrapper">
      <img/>
      <h1>...</h1>
      <p>...</p>
      <div class="currency-info">....</div>
      <div class="author">....</div>
    </div>
</body>
    Marked as helpful
    0
    Himanshu Sahani•30
    @F-a-u-x-LPosted over 2 years ago

    @jasurkurbanovinit Thanks for the feedback, will keep these things in mind :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord