Design comparison
SolutionDesign
Solution retrospective
please feedback about my responsive
Community feedback
- @shikin93Posted over 2 years ago
Hello @denielden, Thank you for the tips,
this is all very helpful
1 - @denieldenPosted over 2 years ago
Hi Chosiin, great work on this challenge! 😉
Here are a few tips for improve your code:
- remove all
margin
from.card-component
class - remove
height
from.card-component__image
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
0 - remove all
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord