NFT preview card component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted about 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the footer element has been placed bottom using margin. So let me explain, How you can place the component at bottom with using absolute positioning for footer

  ---

  ---

  • Luckily you already used Flex layout of css to center the component, So you just want to add fixed position for <footer> element to place it in bottom of the page

  body {
    position: relative;
  }
  
  footer {
     position: absolute;
     bottom: 1em;
  }
  

  ---

  • Now remove these styles, after removing you can able to see the changes

  ---

  .attribution {
    margin: 30px 0;
  }
  

  ---

  • Now your component has been properly at bottom.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Mateusz•180

  @matsta92Posted about 1 year ago

  @0xAbdulKhalid Thanks! I followed the suggestion :)

  0