NFT Card (HTML + CSS)

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 2 years ago

  Hey there, Manuel Salvador! 👋

  Good work on this challenge! 👍

  A couple of things I suggest are,

  • Setting the alt text for the icons in the card component to be an empty string so that they will be ignored by screen readers. That’s because those elements aren't necessary or important to the content of the page and as a result doesn’t need to be read by screen readers.
  • Perhaps making the card component an article tag since it is a standalone component and already contains a heading inside to identify it. That'll make your markup slightly more semtantic! 😉
  • Adding a favicon to the site. There should be one in the starter files for this challenge that you can use.

  Hope you find these suggestions helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  0
• 

  Manuel Salvador•190

  @manuelsclPosted almost 2 years ago

  Hello, @ApplePieGiraffe!

  I already made the changes in my solution, I would like you to take a look and tell me what you think.

  Your suggestions were very useful, thank you <3

  1

  ---

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 2 years ago

  @manuelscl

  Looking good, my friend! The extra touches you added to your solution also look nice. 🙂

  Keep it up! 👍

  0