Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Card (HTML + CSS)

Manuel Salvadorβ€’ 190

@manuelscl

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi, there!

This is my solution to the challenge, Your feedback is highly appreciated <3

Community feedback

T
ApplePieGiraffeβ€’ 30,545

@ApplePieGiraffe

Posted

Hey there, Manuel Salvador! πŸ‘‹

Good work on this challenge! πŸ‘

A couple of things I suggest are,

  • Setting the alt text for the icons in the card component to be an empty string so that they will be ignored by screen readers. That’s because those elements aren't necessary or important to the content of the page and as a result doesn’t need to be read by screen readers.
  • Perhaps making the card component an article tag since it is a standalone component and already contains a heading inside to identify it. That'll make your markup slightly more semtantic! πŸ˜‰
  • Adding a favicon to the site. There should be one in the starter files for this challenge that you can use.

Hope you find these suggestions helpful. 😊

Keep coding (and happy coding, too)! 😁

Marked as helpful

0
Manuel Salvadorβ€’ 190

@manuelscl

Posted

Hello, @ApplePieGiraffe!

I already made the changes in my solution, I would like you to take a look and tell me what you think.

Your suggestions were very useful, thank you <3

1

T
ApplePieGiraffeβ€’ 30,545

@ApplePieGiraffe

Posted

@manuelscl

Looking good, my friend! The extra touches you added to your solution also look nice. πŸ™‚

Keep it up! πŸ‘

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord