Design comparison
Solution retrospective
I'm a little bit new to css so go easy on me. Don't mind the unnecessary tricks I used, its really all I know. Feedback on how I can improve would be highly appreciated,
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <p class="hero__title hero__item"> with <h1> to fix the accessibility issue.
Use the colors that were given in the styleguide.md found in the starter folder for this challenge.
For a more responsive content, use max-width in place of the width. increase the width of .hero for it to match what is in the design, e.g: max-width : 400px instead width: 300px; There is no need to give .hero a height value , the padding value is sufficient for that.
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To
Hope am Helpful. HAPPY CODING
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord