Design comparison
SolutionDesign
Solution retrospective
Hey ! I'm open to any suggestion, I struggled a little bit with the hover effect on the main image.
Community feedback
- @OmarMAttia7Posted almost 3 years ago
Congratulations on finishing the challenge :). You have some problems with HTML markup, most of them are in the report:
- All images must have a meaningful
alt
attribute that describes the image for people who can't view the image visually. - The main content of your page should be inside a
<main>
element, it's preferable that you give it theclass="container"
instead and remove the<div class="container">
as it has no use. - [the footer element should be inside the body element] (https://teamtreehouse.com/community/why-is-the-footer-placed-before-the-closing-of-the-body-tag-and-not-after).
- Any HTML document should have an
<h1>
heading element, in your case you should put<a class='title'>Equilibrium #3429</a>
inside an<h1>
.
Good luck and keep coding <3.
Marked as helpful1@RonanCaPosted almost 3 years ago@hazel79 Thank you very much for your feedback Omar, this is very helpful !
1 - All images must have a meaningful
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord