Responsive card design

Community feedback

• 

  ABDULRAZZAK ALSSSOUKI•180

  @AbdalrzakalsoukiPosted almost 2 years ago

  Hello, good work!

  here are some points to improve:

  • use a main landmark: <main> and you can use <section>, <footer>, <header>, etc (this can solve all the accessibility errors)
  • use a meta description
  • make a specific width and height for all images
  • Solve background and foreground colours sufficient contrast ratio problem by small modfiying for colors All luck!

  0

  ---

  

  Vinay Maurya•140

  @Designer-spacePosted almost 2 years ago

  @Abdalrzakalsouki thanks for the feedback i dont know much about accessibility and meta tag soo as you said ill research a little bit. and as for the width and height i didn't set fixed value because it will loos its responsiveness.

  1

  

  ABDULRAZZAK ALSSSOUKI•180

  @AbdalrzakalsoukiPosted almost 2 years ago

  @vinay3000 Great, researching is the best way to learn, yes you are right, however, if you know the right dimensions of the image, you can use fixed dimensions and keep it responsive. You can always use Lighthouse for this. all luck again

  Marked as helpful

  0