@DavidMorgade
Posted
Hello Goorezy, congrats on finishing the challenge! you did almost get a pixel perfect solution, great job!
In your card__nft--cotainer__hover
I would add a cursor: pointer
to give the user clear intructions that is a clickable!, also increase the time of the effect of the animation to at least 0.5s, it gets smoother in my opinion.
Also would recomment you to set your body { font-size: 16px }
, because you are using html { font-size: 62.5% }
, you can perfectly reset back your font-size in the body to 16px and you will still get rem values as 10px.
Hope my feedback helps you, if you have any question, don't hesitate to ask!
Marked as helpful
@GoorezyEST
Posted
@DavidMorgade I didn't knew that i can reset back the font-size and still get the rem at 10px, I will use that, thanks!
@DavidMorgade
Posted
@GoorezyEST Yeah, this is usually the snippet people use at the start of the CSS to work with rems as 10px without changing the body font-size to only 10px.
html {
/* 1rem = 10px */
font-size: 62.5%;
}
body {
font-size: 1.6rem;
}
I love working with this method, 1rem = 10px is the easiest way to get sizes!
@vanzasetia
Posted
@DavidMorgade and @GoorezyEST, I don't recommend changing the html
or the :root
font size. It can cause huge accessibility implications for those users with different font sizes or zoom requirements. I suggest reading this article by Josh Comeau where he writes about the problem of the 62.5% trick (and more!). Also, I recommend reading what an accessibility expert (Grace Snow) has said about it.