Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Hendry, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - use
min-height: 100vh
insteadheight
to body because Flexbox aligns child items to the size of the parent container and addmargin: 0
for remove the scoolbar of browser - add
hover
on the text with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
Marked as helpful1@hensusantoPosted over 2 years agoHi @denielden, thank you so much for reading my code and giving me feedback with tips, I'll put this in mind. This means something for me, your tips will definitely help me grow as a FE dev.
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord