Design comparison
SolutionDesign
Solution retrospective
if there is any suggestion to make it better feel free to share it with me.๐
Community feedback
- @fernandolapazPosted over 1 year ago
Hi ๐, just a couple of suggestions:
- When there is a hover state over an element it means that it is interactive, so there must be an interactive element around it (like a link or a button). So, we should use a
<a>
or<button>
to wrap the image (depending on what happened when clicking on it). Also 'Equilibrium #3429' and 'Jules Wyvern' should be wrapped with the<a>
tag.
- The icons are decorative images and therefore need an empty
alt
attribute to be ignored by a screen reader.
I hope itโs useful ๐
Great solution.
Regards,
Marked as helpful0@yosrajalaliPosted over 1 year agoHi๐ About interactive elements I figured it out after submitting my solution by checking others' solutions(lazy enough to change it right know๐ฅฑ). but I didn't know about empty alts. I appreciate your help so much๐. @fernandolapaz
1 - When there is a hover state over an element it means that it is interactive, so there must be an interactive element around it (like a link or a button). So, we should use a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord