Skip to content
Submitted over 2 years ago

NFT preview card component

Jax Teller•670
@piushbhandari
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

pros and cons of my css please.

Community feedback

  • Prince Roy•1,210
    @iprinceroyyPosted over 2 years ago

    That's excellent work @piushbhandari. You need to focus on some key points here:-

    1. Yes, these accessibility issues matter in small card components as well as large websites, we need to consider blind users also so for that ARIA is important.
    2. There should be one heading tag on a web page, if there is no heading element requirement, then set its font size to 0. h1{ font-size: 0; }
    3. The content should be wrapped inside the main landmark to avoid accessibility issues. Like this <body><main>your content goes here......</main></body>.

    Hope it adds to your learning. Happy coding :)

    Marked as helpful
    0
  • Lucas 👾•104,340
    @correlucasPosted over 2 years ago

    👾Hello Jax Teller, congratulations for this amazing solution!

    I'll say you what I think about your solution:

    PROS:

    1.The amazing intro animation.

    2.The super flexible solution with many breakpoints.

    3.The cool hover effect changing the card box-shadow.

    CONS:

    1.The transitions animation are too much faster and not smoother, try to use ease-in / ease-out or some complex animation curves like bezier.

    2.The hover effect on the NFT image is cool, but it shows the NFT image borders, you can hide the borders giving the animation a little zoom with transform: scale(1.3);

    3.Amazing hover effects, but these effects stick when the device is touch.

    You've a great solution, you can fix the hover mobile issue using the media query that allows hover effects only in non-touch devices.

    @media (hover:hover) { inside your hover classes here }

    Congratulations and happy coding!

    Marked as helpful
    0
  • Jax Teller•670
    @piushbhandariPosted over 2 years ago

    i've been getting a lotta accessibility issues like missing headers, main, etc. But for small components like this does it really matter? i'm sure when i move onto larger challenges i'll have these in but yeah

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord