NFT preview card component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Gift Charles,

  Congratulation on finishing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • The most important part in this challenge interactive elements, you can use <a> to wrap Equilibrium #3429 and Jules Wyvern.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader. You can read more in MDN

  • Do not use <br> to create margins between paragraphs, wrap them in <p> elements and use the CSS margin property to control their size.

  • For middle part of the card class=” so-plain” , you can use an unordered list <ul>, in each <li> there should be <img> and <p>. That way you can align them centrally.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock ).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be avatar. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <p class="line"></p>, you can use border-top: to the avatar's part.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.

  Aside these, great job on this one . Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Gift Charles•50

  @GiftCode27Posted about 2 years ago

  @PhoenixDev22 Thanks a lot.

  0

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @GiftCode27 You’re welcome. Happy coding!

  0