NFT preview card component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello hatimH,

  Great work! Congratulation on completing this challenge. I have some suggestions regarding your solution if you don't mind:

  • Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) For this imagine what would happen when you click on the image, there are two possible ways:

  1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>.

  2:If clicking the image would navigate the user to another page to see the NFT, here use <a>.

  • Also use <a> to wrap Jules Wyvern and Equilibrium #3429 and Jules Wyvern.

  • The link wrapping the equilibrium image (image-equilibrium ) should either have Sr-only text, an aria-labelor alt text of the image that indicates where the link navigate the user(not describes the image).

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in(icon-view, icon-ethereum, icon-clock ).

  • Never use <div> and <span> alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • You can use unordered list<ul> to wrap class="values". In each <li> should be <img> and <p>, then you may use flex properties to align them centrally.

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • The avatar's alt should not be icon avatar, it’s meaningless. You can use the creator's name Jules Wyvern. Read more how to write an alt text . For future use, the alternate text should not be hyphenated, it should be human readable.

  • To use more semantic tags , you may use <figure> and <figcaption> for the avatar's part.

  • There are so many ways to add the hover effect on the image , The one I would use, using pseudo-elements to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo element on hover.The icon view doesn’t really need to be in HTML as there is no need for a extra clutter in the HTML. You can have a look at my solution here, it might help.

  Aside these, your solution is good. Hopefully this feedback helps

  Marked as helpful

  0

  ---

  

  ...•600

  @HatimHJPosted over 2 years ago

  @PhoenixDev22 thanks for the feedback . i tried some of your suggestions

  0