Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT preview card component

@JamieShortz

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Finished this within a week or two but have not decided to upload it until now. What do you guys think?

Community feedback

Mikhail 440

@MikeBeloborodov

Posted

Hey! Nicely done work! Some feedback:

  • Try to avoid styling with IDs, use classes for that to avoid problems with rules priority (for example if you style ID it's priority is higher than classes, etc.)

  • Try to use rem and em units instead of pixels for better accessability (so that users could change font-size of their browser and your page will adjust).

  • Add an empty line after every selector in your css file, for example

body {
margin: 0;
}
h1 {
font-size: 1rem;
}

is bad, instead do this:

body {
margin: 0;
}

h1 {
font-size: 1rem;
}

Good luck!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord