NFT preview card component

Community feedback

• 

  Mohamed Abdessamed•140

  @Brivan-26Posted almost 3 years ago

  Nice try @Kalim22, your work was great, but I see that you didn't respect design's guides:

  1. Try to add fonts that are provided in style-guide.md
  2. The main card and the image need to have a border-radius
  3. The main card needs to have more padding.
  4. You have extra padding on the bottom of the pricing div
  5. the profile image needs to have a border of 2px with white color
  6. In your CSS, you are using a lot of positions absolute and relative, especially to the photos; try to avoid using them. For the Accessibility issues:
  7. Wrap your main content inside <main> tag
  8. Add the challenging signature inside the <footer> tag and most of the problems will be solved.

  1

  ---

  

  Kalim•70

  @Kalim22Posted almost 3 years ago

  Thank you @Brivan-26

  It would be great when some one look for you and help you to improve your skill and tell you what you have to do.

  It is first time when someone tells me that you are doing it wrong. Till now, I am doing by myself.

  I hope you will keep telling me like this in future.

  0