NFT preview card component

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey Carlos, It looks good!... Here are some suggestions:

  • Document should have one main landmark, Contain the component with <main>.

  <main>
     <div class="container">
        //...
     </div>
  </main>
  

  • Page should contain a level-one heading, Change h2 to h1 You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  I hope this is useful to you... Keep coding👍

  Marked as helpful

  0

  ---

  

  Carlos H.•90

  @KrossBRPosted over 2 years ago

  @Bayoumi-dev Thanks for that golden tip.

  I will correct and use in the next solutions 😊

  Note: I used h2, thinking of an element that could be added to a page at some point.

  0
• 

  jaya•0

  @Jayakumar03Posted over 2 years ago

  no, it's not good idea to keep value fixed, use responsive value like percentage, rem or em.

  1

  ---

  

  Carlos H.•90

  @KrossBRPosted over 2 years ago

  @maverick-ns Thanks for the tip 😉

  0