Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT preview card component

@tahakhairy

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone, this is my first challenge and I welcome any comment or feedback, thanks.

Community feedback

bikeinman 1,080

@BikeInMan

Posted

I think you did a good job.

Apart from the validator errors, I would like to recommend the following:

  1. Using header tags(h4 etc) for sizing is not recommended. Try to use p and adjust size in css for them.
  2. If you were to use flex on your .info , just like you did on .container you would have better alignment in an easier way.
  3. May be you can simplifying a bit more, but not adding classes at all to h3 etc., because they are easily accessible in css via selectors.
  4. Use divs only to group elements and to style as a group.

Good Luck.

Marked as helpful

0

@tahakhairy

Posted

@BikeInMan Thank you very much for the feedback.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord