Design comparison
Solution retrospective
Feel free to leave some feedback. Very much appreciated!
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hello Sebastian, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:
I noticed that this image is not showing, to fix it do this:
<img src="./images/icon-view.svg">
images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty
alt=""
and addaria-hidden="true"
attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.To improve the code structure wrap this div:
<div class="attribution">
with the semantic tag
footer
The remainder is excellent.
I hope it's useful. 👍
Marked as helpful0 - @GuldspjutetPosted almost 2 years ago
Hi Adriano. I'm very good this friday afternoon. I hope your day is going well also :). Thank you so much for the feedback. It was very helpful. Il try to improve on these things!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord