NFT preview card component

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey Carvalho, It looks good!...

  My suggestions:

  • Document should have one main landmark, Contain the component with <main>.

  <main>
     <div class="content">
        //...
     </div >
  </main>
  

  • Page should contain a level-one heading, Wrap <a href="#" class="name">Equilibrium #3429</a> with <h1>

  <h1><a href="#" class="name">Equilibrium #3429</a><h1>
  

  You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • There is an issue with the view-icon transparent... to fix it, Use background-color: hsla(178, 100%, 50%, 0.5); instead of background-color: #00FFF8; and change opacity: 0.5; to opacity: 1;

  .overlay {
    //...
    background-color: hsla(178, 100%, 50%, 0.5);   /* changed */
  }
  .preview:hover .overlay {
         /* mix-blend-mode: normal;    <---Rmove */
          opacity: 1;   /* changed */
         /* border-radius: 8px;     <---Rmove */
         /* background: #00FFF8;     <---Rmove */
          cursor: pointer;
  }
  

  Hope this is helpful to you... Keep coding👍

  Marked as helpful

  1

  ---

  

  CarvalhoVincent•500

  @CarvalhoVincentPosted over 2 years ago

  @Bayoumi-dev I fixed it all with your help. I knew for the view-icon transparent but wasn't able to find a solution. This is clearly helpful ! Thank you for your time !

  0