NFT Component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The NFT image alt tag description needs to be improved upon. This is what your users are purchasing. Assume you’re describing the image to someone over the phone.

  • The “Icons” serve no other purpose than to be decorative; They add no value. Their alt tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The "Equilibrium #3429" is a heading so it needs to be wrapped inside a heading element.

  • The profile image alt tag needs to be improved. It should only state the following; “Headshot of -person’s full name-“

  More Info:📚

  Headshot Alt Text

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎄🎁

  Marked as helpful

  0

  ---

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  • The web development process can be made easier and expedite the process by implementing a CSS Reset.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-size and other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  Marked as helpful

  0

  

  Enn ko•230

  @enn-koPosted almost 2 years ago

  @vcarames Thank you for your kindness and this is very helpful to improve my coding skill.

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @ennko

  Glad I could help!☃️

  Keep it up!

  Marked as helpful

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  <div role="main" class="container"> with the main tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

  To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Enn ko•230

  @enn-koPosted almost 2 years ago

  @Hassiai Thank you for your advice

  0