Design comparison
Solution retrospective
Feel free to give any feedback or suggestions! Please let me know the things I could improve.
Community feedback
- @jhonGriGiPosted almost 2 years ago
Hello, I would change only 3 things in your code:
1: Your body tag should have a main tag that surrounds your code:
<body> <main> // Enter your code here. </main> <body>2: Replace your last div tag with a footer tag:
<footer class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Shahzaman</a>. </footer>These two changes help with the accessibility issues and the screen reader that helps blind people.
3: In your CSS code, don't use the html tag; instead, use a class or id attribute. If you want to change the tag, you just need to change the html and not the CSS. This makes your code easy to read.
Finally, I would recommend BEM: https://israelmitolu.hashnode.dev/writing-cleaner-css-using-BEM-methodology, Good job with your solution.
0@Shazee17Posted almost 2 years ago@jhonGriGi Thank you and yes i'll keep that in mind
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord