Submitted over 1 year ago

NFT preview card component

Piwko Marcin• 180

@PiwkoO

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

I would really appreciate any feedback 🤓

Community feedback

Shivraj K• 400

@Shivraj-K09

Posted over 1 year ago

Your solution looks great! One suggestion I have is to consider using min-height: 100vh instead of height: 100% for the body element's styling.
This ensures that the body covers the entire viewport height, even if there's not enough content to fill up the page. This can prevent issues where the background color cuts off prematurely. Overall, great job and keep up the good work! Happy Coding buddy 😉

Marked as helpful

Piwko Marcin• 180

@PiwkoO

Posted over 1 year ago

Hi @Shivraj-K09, thank you for your feedback 🙂

You're right even if this is just a placeholder value it'd be better if it just works well only on the desktop when script would fail.

Ojo Isaac• 0

@Sabali11

Posted over 1 year ago

can i also do this without javascript? just pure html and css??

Piwko Marcin• 180

@PiwkoO

Posted over 1 year ago

Hi @Sabali11,

I looked for other solutions but at this moment I couldn't find anything else to make it work with mobile devices except JavaScript

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord