Design comparison
Solution retrospective
Hi, this is my second Challenge complete. ¡Any suggest are welcome!
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Dave, Congratulations on completing this challenge!
Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:
1.Use units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.2.The box-shadow is a bit too strong, this is due the
opacity
andblur
. The secret to create a perfect and smooth shadow is to have low values foropacity
and increaseblur
try this value instead:box-shadow: 12px 7px 20px 6px rgb(57 75 84 / 8%);
3.If you’re not familiar to box-shadow you can use this site to create the shadow design and then just drop the code into the CSS: https://html-css-js.com/css/generator/box-shadow/
✌️ I hope this helps you and happy coding!
Marked as helpful0@GalerinPosted about 2 years ago@correlucas I really appreciate your suggestions, I will keep them in mind for the next challenges. Thank you very much!
2 - @rakibhossainrajuPosted about 2 years ago
Really good work man!! Except the box-shadow everything was almost the same. And i have to mention how nicely you have structure your code. In-fact I refactor my code after watching how well you code management is. Hopefully you will do great. GOOD LUCK !!
0@GalerinPosted about 2 years ago@Zubair1020 Thank you very much. I am glad to hear that you found my structure useful. Good luck to you too!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord