Design comparison
SolutionDesign
Solution retrospective
All Feedbacks are welcomed. Thank you
Community feedback
- @MelvinAguilarPosted over 1 year ago
Hello ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- You should wrap the image, title, and creator's name in an
<a>
tag, since an element has a :hover state it is considered an interactive element (buttons, links, etc).
- Use
min-height: 100vh
instead ofheight
. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
- The
alt
attribute is used to provide a text description of the image which is useful for screen reader users and assistive technology users,favicon-32x32
is not a good alt attribute. If you think the image is decorative, you should leave the alt attribute empty, but if it's important content, add a description of the image.
I hope you find it useful! ๐
Happy coding!
Marked as helpful0 - You should wrap the image, title, and creator's name in an
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord