NFT Preview Card Component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="card"> with the main tag and <span class="card-title"> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .nft-content on the page using flexbox, replace the height in .card with min-height: 100vh.

  There is no need to give the body a width and height value.

  Replace the height in .nft-content with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement. padding: 15px .

  Give .image-wrapper a width of 100% and give the img a width of 100% and height of 100%. there is no need to give the img a margin-top value.

  For a responsive content, replace the width in .nft-content with a max-width.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Tom Cieslukowski•130

  @cieslukPosted over 1 year ago

  @Hassiai Thank you for the comment, it really helps me learn and become better at web development. Appreciate it!

  1