NFT-preview-card-component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  HTML:

  • Use the <main> tag to wrap all the main content of the page instead of the <div class="card"> tag. With this semantic element you can improve the accessibility of your page.

  • The image with the "avatar" author is not a decoration, you need to provide an alternative text to tell the user who is the author of the card, its recommended to use the author's name as the alt attribute value. e.g. alt="Jules Wyvern"

  If you want to learn more about the alt attribute, you can read this article.

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.

  body {
      /* font-size: 18px; */
      font-size: 1.125rem;
      .  .  .
  }
  

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Endo_hr•60

  @EndoHrPosted almost 2 years ago

  @MelvinAguilar thx for the feedback, I thought defining font-size in body (font-size: 18px in body), --> turns into 1em = 18px xd

  1

  

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  @EndoHr True, my apologies, I thought you was changing the font-size in the :root, not in the body, but, since all the units are in rem, the font-size in the body is a bit unnecessary

  Marked as helpful

  0

  

  Endo_hr•60

  @EndoHrPosted almost 2 years ago

  @MelvinAguilar can u help me and give some feedbacks on that xd, (if u wanted), here is my post https://frontendmentor.slack.com/archives/CCYHFT85B/p1672718226212379

  0
• 

  Yahya•80

  @yhas14Posted almost 2 years ago

  Wow spot on! Well done, I would look at the accessibility and try to apply them. Otherwise it's perfect.

  1