NFT Preview Card Component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .main-container{
  margin: 0 auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Ed-dyb Abdelilah•1,560

  @eddybproPosted over 1 year ago

  Hi, Aaryn

  You did a good job, for the hover issue here a way to solve it:

  • HTML code

  <div class="image-container">
  <img class="view" src="view-image-path">
  </div>
  

  • CSS code

  .img-container{
  height: 30rem;
  background: url('images/image-equilibrium.jpg');
  background-position: center;
  background-repeat: no-repeat;
  background-size: cover;
  display: flex;
  align-items: center;
  justify-content: center;
  cursor: pointer;
  margin-bottom: 1rem;
  border-radius: 10px;
  }
  
  .img-container:hover{
  box-shadow: inset 0 0 0 1000px var(--cyan-bg);
  }
  
  .img-container:hover .view{
  display: block;
  }
  
  .img-container .view{
  display: none;
  }
  

  Tips

  • You don't need to give the body element width property.

  • Make sure to update the value of the property background-repeat to no-repeat.

  • Start using relative values em, rem instead of absolute values px.

  Again you did a nice work.

  Congratulation for finishing this challenge:)

  0