NFT preview card component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .card {
     margin-left: auto;
     margin-right: auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Candido Hernandez Martin•310

  @Candido-HMPosted over 1 year ago

  @0xAbdulKhalid This is how it is in the case of flexbox would be: body{ display: flex; justify-content: center; align-items: center; } This will center the component.

  Marked as helpful

  0

  

  devAelo•30

  @devAeloPosted over 1 year ago

  @Candido-HM Thank you it's helpful for me.

  1

  

  devAelo•30

  @devAeloPosted over 1 year ago

  @0xAbdulKhalid thank you it's very helpful to me.

  0