Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT preview card component with Flexbox.

GGSβ€’ 260

@Guilherme-Goncalves-de-Souza

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


πŸ‡§πŸ‡· Deixe aqui seu feedback ou sua crΓ­tica construtiva!!!

en Leave your feedback or constructive criticism here!!!

Community feedback

@VCarames

Posted

Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

  • The NFT alt tag description needs to be improved upon. This is what your users are purchasing. You want to describe what the image is; Assume you’re describing the image to someone over the phone.
    • The β€œIcons” serve no other purpose than to be decorative; They add no value. Their alt tag should left blank and have an aria-hidden=β€œtrue” to hides it from assistive technology.

More Info:πŸ“š

https://www.w3.org/WAI/tutorials/images/

  • Wrap the "NFT image", "Equilibrium #3429" and "Jules Wyvern" in an anchor tags. The anchor tag will allow users to click on content and have them directed to another part of your site.

More Info:πŸ“š

MDN The Anchor element

  • Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.

Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.

Josh Comeau Reset

Eric Meyer Reset

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! πŸŽ„πŸŽ

Marked as helpful

1

GGSβ€’ 260

@Guilherme-Goncalves-de-Souza

Posted

Thank you very much for all the feedback, mainly for the "aria-hidden" did not know that this existed.

Thank you very much @vcarames !!!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord