@denielden
Posted
Hello Muhriz, You have done a good work! 😁
Some little tips to improve your code:
- use
main
tag to wrap the card and improve the Accessibility but not as a container of that one element - also you can use
article or div
tag instead ofmain
to the container card for improve the Accessibility - You can add the effect
:hover
creating adiv
that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution - to make it look as close to the design as possible add
width: 22rem
to the card container - use
min-height: 100vh
to body instead ofheight
, otherwise the content is cut off when the browser height is less than the content
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
@muhrizmrz
Posted
@denielden use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content. This point I don't understand
@denielden
Posted
@muhrizmrz if you use height: 100vh
you tell the browser that the height of your page is equal to the screen and no more, so in smaller screens where the design goes out of the screen size the content is cut off and you can't see it all
Marked as helpful