NFT Preview Card Component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Marco, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • use p for the text of card instead of h4
  • add min-height: 100vh to section tag because Grid aligns child items to the size of the parent container
  • remove margin-top from card class
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  0
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  HI @marconarca,

  Nice job on the completing the challenge

  The card looks slightly off center you can a min-height: 100vh; to your section to place it in the middle of the page.

  0