Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Preview Card Component

@marconarca

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Can I receive some feedback whether I need some changes with how I write the HTML and CSS ? Thank you!

Community feedback

Travolgi πŸ•β€’ 31,420

@denielden

Posted

Hi Marco, congratulations on completing the challenge, great job! 😁

Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • use p for the text of card instead of h4
  • add min-height: 100vh to section tag because Grid aligns child items to the size of the parent container
  • remove margin-top from card class
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

Hope this help! Happy coding πŸ˜‰

0
Hyronβ€’ 5,870

@hyrongennike

Posted

HI @marconarca,

Nice job on the completing the challenge

The card looks slightly off center you can a min-height: 100vh; to your section to place it in the middle of the page.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord