Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Preview Card Component

asdiAdiβ€’ 130

@asdiAdi

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Edited to match figma design 1:1 as closes as possible. All feedbacks are welcome :D

Community feedback

Travolgi πŸ•β€’ 31,420

@denielden

Posted

Hello asdiAdi, You have done a good work! 😁

Some little tips to improve your code:

  • use main tag to wrap the card and improve the Accessibility but not as a container of that one element
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

Keep learning how to code with your amazing solutions to challenges.

Hope this help πŸ˜‰ and Happy coding!

Marked as helpful

1
Adebisiβ€’ 330

@adebisiabdussamad

Posted

Cheers asdiAdi πŸ₯‚ on completing this challenge.. .

An img element must have an alt attribute. This enables physical challenge to understand the image better.

-This is your code:<img src="./assets/icon-ethereum.svg" >

-This is how it should be:<img src="./assets/icon-ethereum.svg" alt="">the second one with the alt attritube. to know more about the alt attribute you can click this link Img element

You need to apply the alt for both of your images your code is really amazing...

hope you find this helpful...

Happy coding!!!πŸ‘ŒπŸ‘

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord