NFT Preview Card Component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hello asdiAdi, You have done a good work! 😁

  Some little tips to improve your code:

  • use main tag to wrap the card and improve the Accessibility but not as a container of that one element
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1
• 

  Adebisi•350

  @adebisiabdussamadPosted about 2 years ago

  Cheers asdiAdi 🥂 on completing this challenge.. .

  An img element must have an alt attribute. This enables physical challenge to understand the image better.

  -This is your code:<img src="./assets/icon-ethereum.svg" >

  -This is how it should be:<img src="./assets/icon-ethereum.svg" alt="">the second one with the alt attritube. to know more about the alt attribute you can click this link Img element

  You need to apply the alt for both of your images your code is really amazing...

  hope you find this helpful...

  Happy coding!!!👌👍

  0