NFT Preview card Challange

Community feedback

• 

  Oskar•330

  @slothmast3rPosted almost 3 years ago

  Hey man! Great work! What I recommend is using also em in your code. Here is quick video by Kevin Powell explaining rem's and em's https://www.youtube.com/watch?v=ZjiJIIL60GI

  0
• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Great job in making this project. Viewing your solution you did well in implementing the design. I think you should considered the following as well.

  • It's common to use div to wrap the contents but for best practices use a specific tag for it's functionality. Like the container wrap it with main tag.
  • Same goes with attribution wrap it with footer tag which is more relevant to use
  • It's better to use section tag instead of article mainly because a heading followed to the tag
  • Use a validator to check your solution for readability

  Hope this helps and keep up the good work!

  0