Design comparison
SolutionDesign
Solution retrospective
Greetings fellow programmers, I present my implementation of the NFT preview card challenge on Frontend Mentor. I eagerly seek your constructive feedback on the project. ๐
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- When you use the hover effect and cursor: pointer on an element, it usually implies interactivity. To enhance user experience, consider wrapping the name of the "Equilibrium #3429" text in an
<a href="#">
tag. This way, users can click on it, expecting some action, like navigating to a page with more information about the collection. The same concept applies to the image; consider making it a clickable link for consistency.
- Use
min-height: 100vh
instead ofheight
. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
I hope you find it useful! ๐
Happy coding!
Marked as helpful1@HosseinHeydarpourPosted 11 months ago@MelvinAguilar Hi! Thanks a lot the tip about min-height you mentioned in your comment helped me a lot! that was the exact problem i encountered every single time! Thanks a lot! Also i will change my code nice tips about <a> i did not think about!
1 - When you use the hover effect and cursor: pointer on an element, it usually implies interactivity. To enhance user experience, consider wrapping the name of the "Equilibrium #3429" text in an
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord